Skip to content

feat(attributes): Add aws.request.url (deprecated) in favor of url.full#488

Open
sentrivana wants to merge 2 commits into
mainfrom
ivana/add-deprecated-aws-request-url
Open

feat(attributes): Add aws.request.url (deprecated) in favor of url.full#488
sentrivana wants to merge 2 commits into
mainfrom
ivana/add-deprecated-aws-request-url

Conversation

@sentrivana

Copy link
Copy Markdown
Contributor

Summary

  • Adds aws.request.url as a deprecated attribute with url.full as its replacement
  • Adds aws.request.url to the existing alias list on url.full (alongside http.url and url)

Test plan

  • yarn test passes (7592 JS tests + 3 Python tests)
  • yarn run generate ran successfully

🤖 Generated with Claude Code

….full`

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Attributes

  • Add aws.request.url (deprecated) in favor of url.full by sentrivana in #488
  • Add sentry.metric.source by klochek in #476
  • Add faas.id (deprecated) in favor of cloud.resource_id by andreiborza in #475
  • Add faas.execution (deprecated) in favor of faas.invocation_id by andreiborza in #473
  • Add messaging attributes by s1gr1d in #469
  • Add url.same_origin (deprecated) and http.request.same_origin (replacement) attributes by Lms24 in #456
  • Add db.response.status_code by s1gr1d in #462

Other

  • (ai) Add granular cost attributes for cache and reasoning by vgrozdanic in #461

Internal Changes 🔧

  • (ci) Stop inheriting secrets for changelog-preview by tobias-wilfert in #463

🤖 This preview updates automatically when you update the PR.

@sentrivana sentrivana marked this pull request as ready for review July 10, 2026 09:34
@sentrivana sentrivana requested review from a team, Lms24, cleptric, mjq and nsdeschenes as code owners July 10, 2026 09:34
Comment thread model/attributes/aws/aws__request__url.json Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 82dc1bb. Configure here.

Comment thread model/attributes/aws/aws__request__url.json Outdated
… alias group

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Comment on lines +17629 to 17632
aliases: ['url.full', 'http.url', 'url'],
changelog: [{ version: 'next', description: 'Added aws.request.url attribute, deprecated in favor of url.full' }],
},
blocked_main_thread: {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The JavaScript code generation for attribute metadata omits the deprecation._status field, unlike the Python generation, leading to incomplete deprecation information in the generated JS file.
Severity: MEDIUM

Suggested Fix

Update the generateMetadataDict function for JavaScript to handle the deprecation._status field, similar to the Python generation logic. This includes adding a status field to the TypeScript DeprecationInfo interface and then populating it in the generation script, ensuring the generated JavaScript metadata contains the complete deprecation information.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: javascript/sentry-conventions/src/attributes.ts#L17629-L17632

Potential issue: The `generateMetadataDict` function in the code generation script does
not include the `deprecation._status` field when generating the JavaScript metadata
dictionary. This is in contrast to the Python generation logic, which correctly
processes and includes this field. As a result, the generated JavaScript
`AttributeMetadata` for deprecated attributes, such as `aws.request.url`, is missing the
`status` field within its `deprecation` object. This asymmetry means consumers of the
JavaScript metadata cannot distinguish between different deprecation types (e.g.,
'backfill'), unlike consumers of the Python metadata.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not introduced by this PR afait

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yeah the bot sometimes flags this but I don't think the status has any value for the generated JS. If anyone needs it, we can adjust it but feel free to ignore for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants