feat(attributes): Add aws.request.url (deprecated) in favor of url.full#488
feat(attributes): Add aws.request.url (deprecated) in favor of url.full#488sentrivana wants to merge 2 commits into
aws.request.url (deprecated) in favor of url.full#488Conversation
….full` Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 82dc1bb. Configure here.
… alias group Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
| aliases: ['url.full', 'http.url', 'url'], | ||
| changelog: [{ version: 'next', description: 'Added aws.request.url attribute, deprecated in favor of url.full' }], | ||
| }, | ||
| blocked_main_thread: { |
There was a problem hiding this comment.
Bug: The JavaScript code generation for attribute metadata omits the deprecation._status field, unlike the Python generation, leading to incomplete deprecation information in the generated JS file.
Severity: MEDIUM
Suggested Fix
Update the generateMetadataDict function for JavaScript to handle the deprecation._status field, similar to the Python generation logic. This includes adding a status field to the TypeScript DeprecationInfo interface and then populating it in the generation script, ensuring the generated JavaScript metadata contains the complete deprecation information.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: javascript/sentry-conventions/src/attributes.ts#L17629-L17632
Potential issue: The `generateMetadataDict` function in the code generation script does
not include the `deprecation._status` field when generating the JavaScript metadata
dictionary. This is in contrast to the Python generation logic, which correctly
processes and includes this field. As a result, the generated JavaScript
`AttributeMetadata` for deprecated attributes, such as `aws.request.url`, is missing the
`status` field within its `deprecation` object. This asymmetry means consumers of the
JavaScript metadata cannot distinguish between different deprecation types (e.g.,
'backfill'), unlike consumers of the Python metadata.
There was a problem hiding this comment.
Not introduced by this PR afait
There was a problem hiding this comment.
ah yeah the bot sometimes flags this but I don't think the status has any value for the generated JS. If anyone needs it, we can adjust it but feel free to ignore for the moment.

Summary
aws.request.urlas a deprecated attribute withurl.fullas its replacementaws.request.urlto the existing alias list onurl.full(alongsidehttp.urlandurl)Test plan
yarn testpasses (7592 JS tests + 3 Python tests)yarn run generateran successfully🤖 Generated with Claude Code