Skip to content

feat(attributes): Add faas.invoked_* attributes#481

Merged
andreiborza merged 2 commits into
mainfrom
ab/faas-invoked-attributes
Jul 10, 2026
Merged

feat(attributes): Add faas.invoked_* attributes#481
andreiborza merged 2 commits into
mainfrom
ab/faas-invoked-attributes

Conversation

@andreiborza

@andreiborza andreiborza commented Jul 10, 2026

Copy link
Copy Markdown
Member

Adds the faas.* attributes emitted by the vendored JS AWS SDK instrumentation.

  • invoked_name
  • invoked_provider
  • invoked_region

OTel sem conv for faas.* can be found at: https://opentelemetry.io/docs/specs/semconv/registry/attributes/faas/

@andreiborza andreiborza requested review from a team, Lms24, cleptric, mjq and nsdeschenes as code owners July 10, 2026 09:05
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Attributes

  • Add faas.invoked_* attributes by andreiborza in #481
  • Add AWS DynamoDB instrumentation attributes by andreiborza in #479
  • Add sentry.metric.source by klochek in #476
  • Add faas.id (deprecated) in favor of cloud.resource_id by andreiborza in #475
  • Add faas.execution (deprecated) in favor of faas.invocation_id by andreiborza in #473
  • Add messaging attributes by s1gr1d in #469
  • Add url.same_origin (deprecated) and http.request.same_origin (replacement) attributes by Lms24 in #456
  • Add db.response.status_code by s1gr1d in #462

Other

  • (ai) Add granular cost attributes for cache and reasoning by vgrozdanic in #461
  • (js) Add _BASE attribute key exports for dynamic attribute keys by Lms24 in #471

Internal Changes 🔧

  • (ci) Stop inheriting secrets for changelog-preview by tobias-wilfert in #463

🤖 This preview updates automatically when you update the PR.

@andreiborza andreiborza force-pushed the ab/aws-service-attributes branch from 718de2a to 9046f3c Compare July 10, 2026 09:07
@andreiborza andreiborza force-pushed the ab/faas-invoked-attributes branch from fc8c03f to acfd7bb Compare July 10, 2026 09:07
@andreiborza andreiborza changed the base branch from ab/aws-service-attributes to main July 10, 2026 11:37
Co-Authored-By: Claude <noreply@anthropic.com>
@andreiborza andreiborza force-pushed the ab/faas-invoked-attributes branch from acfd7bb to 2a47ae1 Compare July 10, 2026 12:11

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given that these attributes (according to otel) should be equal to more general attributes: Can we set the alias field and link to them?

No need to deprecate then, since they're also not deprecated in OTel. Though I wonder why OTel permits this duality 😅

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 9c79791. Configure here.

Comment thread model/attributes/faas/faas__invoked_provider.json Outdated
Comment thread model/attributes/faas/faas__invoked_provider.json Outdated
@andreiborza andreiborza force-pushed the ab/faas-invoked-attributes branch from 9c79791 to 2a47ae1 Compare July 10, 2026 12:42

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline: No need for the alias. These should be the same value but it's not a bidirectional relationship.

@andreiborza

Copy link
Copy Markdown
Member Author

given that these attributes (according to otel) should be equal to more general attributes: Can we set the alias field and link to them?

No need to deprecate then, since they're also not deprecated in OTel. Though I wonder why OTel permits this duality 😅

I read that more as a "these should have equal value when set" but not necessarily that these are aliases of each other. As discussed, probably better to keep as is.

@andreiborza andreiborza merged commit 75e3e67 into main Jul 10, 2026
17 checks passed
@andreiborza andreiborza deleted the ab/faas-invoked-attributes branch July 10, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants