feat(attributes): Add faas.invoked_* attributes#481
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
718de2a to
9046f3c
Compare
fc8c03f to
acfd7bb
Compare
Co-Authored-By: Claude <noreply@anthropic.com>
acfd7bb to
2a47ae1
Compare
Lms24
left a comment
There was a problem hiding this comment.
given that these attributes (according to otel) should be equal to more general attributes: Can we set the alias field and link to them?
No need to deprecate then, since they're also not deprecated in OTel. Though I wonder why OTel permits this duality 😅
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9c79791. Configure here.
9c79791 to
2a47ae1
Compare
Lms24
left a comment
There was a problem hiding this comment.
As discussed offline: No need for the alias. These should be the same value but it's not a bidirectional relationship.
I read that more as a "these should have equal value when set" but not necessarily that these are aliases of each other. As discussed, probably better to keep as is. |

Adds the
faas.*attributes emitted by the vendored JS AWS SDK instrumentation.OTel sem conv for
faas.*can be found at: https://opentelemetry.io/docs/specs/semconv/registry/attributes/faas/