feat(attributes): Add server_name (deprecated) and sentry.metric.source#477
Open
cleptric wants to merge 6 commits into
Open
feat(attributes): Add server_name (deprecated) and sentry.metric.source#477cleptric wants to merge 6 commits into
server_name (deprecated) and sentry.metric.source#477cleptric wants to merge 6 commits into
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
…er.address` Add server_address as a deprecated attribute pointing to server.address as the correct OTel-aligned replacement. Update server.address aliases to include server_address for symmetry. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
63d97a3 to
0e89b2f
Compare
The generated attributes file was out of sync with the model, causing CI to fail on the uncommitted-changes check. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This reverts commit 9be3515.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f4ab733. Configure here.
Add `server_address` to the alias lists of `http.server_name`, `net.host.name`, and `http.host`, and add those three to the alias list of `server_address`. This ensures every member of the alias group references every other member, matching the pattern used by other deprecated attributes like `faas.execution`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sentrivana
approved these changes
Jul 10, 2026
Lms24
approved these changes
Jul 10, 2026
ericapisani
approved these changes
Jul 10, 2026
server_address (deprecated) in favor of server.addressserver_name (deprecated) and sentry.metric.source
…ted) The deprecated attribute should be server_name, not server_address. Update all alias references across the server.address alias group. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ddd7d3a to
237ab20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add
server_nameas a deprecated attribute pointing toserver.addressas the OTel-aligned replacement, following the same pattern as other recent deprecations (faas.id→cloud.resource_id,faas.execution→faas.invocation_id). Theserver.addressalias list is updated to includeserver_name.Also adds the new
sentry.metric.sourceattribute.