Repository navigation
test: Read relative spec paths now that the spec ships them - #153
Merged
Merged
Conversation
The synced spec's paths are relative to the server URL's /api/0, so the two tests that still looked up or compared full /api/0 paths failed and kept main red. Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
sentry-junior
Bot
requested review from
BYK,
MathurAditya724 and
betegon
as code owners
November 13, 2026 15:36
BYK
approved these changes
Nov 13, 2026
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main has been red since the spec sync from getsentry/sentry#131065 landed (36d0d11). That sync made spec paths relative to the server URL's
/api/0. Two tests still look up or compare full/api/0paths, so Build fails and no@sentry/apirelease goes out until this lands.test/descriptions.test.ts(from fix(validators): Keep the field description of single-member allOf fields #142):spec.paths["/api/0/organizations/{organization_id_or_slug}/dashboards/"]→spec.paths["/organizations/{organization_id_or_slug}/dashboards/"]test/docs.test.ts(from feat(api): Export API reference data as @sentry/api/docs #150, written against the old spec), comparing the export's paths with the spec's:`${operation.method} ${API_BASE_PATH}${operation.path}`→`${operation.method} ${operation.path}`No other test reads
spec.pathsby a full/api/0key. The remaining/api/0strings in tests are request URLs, which are still correct.Checks:
pnpm build,pnpm typecheck,pnpm test(681 passed) andcheck-script-modes.shpass.via @BYK.
--
View Session [Sentry]