-
Notifications
You must be signed in to change notification settings - Fork 120
feat(eap): Implement gen_ai attribute transformations #6201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
constantinius
wants to merge
6
commits into
master
Choose a base branch
from
constantinius/feat/eap/gen-ai-attribute-transformations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a39c1a1
feat(eap): implement gen_ai attribute transformations
constantinius 6e7299f
fix(conventions): remove unneeded return statement
constantinius 5335782
fix(eap): run gen_ai transformations on all span paths
constantinius 62ec370
fix(test): update test expectation for non-JSON tool_calls
constantinius 16f88a2
docs: add changelog entry for gen_ai attribute transformations
constantinius aa94a95
fix(eap): address review feedback on gen_ai transformations
constantinius File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule sentry-conventions
updated
30 files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Deprecated AI attributes are not transformed if the span lacks an operation attribute, as the
normalize_aifunction is skipped, leading to data loss.Severity: LOW
Suggested Fix
The transformation logic should be moved to a place where it can handle these legacy attributes unconditionally, or the
is_ai_item()guard should be updated to also check for the presence of deprecated AI attributes to ensure they are always processed.Prompt for AI Agent