feat(playstation): Upload non-prosperodmp attachments#5673
Open
feat(playstation): Upload non-prosperodmp attachments#5673
Conversation
Stream non-prosperodmp attachments to objectstore instead of adding them to the envelope. By not reading attachments into memory, they are not limited to max_attachment_size, allowing customers to send large attachments such as memory dumps to the playstation endpoint.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
elramen
commented
Feb 27, 2026
Comment on lines
+254
to
+258
| if let Ok(location) = location.and_then(|l| l.into_header_value()) { | ||
| item.set_payload( | ||
| ContentType::AttachmentRef, | ||
| location.as_bytes().to_owned(), | ||
| ); |
Member
Author
There was a problem hiding this comment.
@jjbayer Should we emit an outcome here if the upload fails? Or is that already taken care of elsewhere?
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stream non-prosperodmp attachments to objectstore instead of adding them to the envelope. By not reading attachments into memory, they are not limited in size to max_attachment_size, allowing customers to send large attachments such as memory dumps to the playstation endpoint.