Skip to content

A read tool's card makes a noReply note visible #3358

Closed

Description

@sentry-junior

An Event Turn that ends with noReply and a note should store the note as a Quiet message. deliverAssistantMessage in chat/task-execution/conversation-turn.ts keeps quiet only when cards.length === 0. Commit 270b94f (#2659) added this rule for a reply that carries a card. But loadPendingMessageCards also returns the object cards of read-only tools such as github_getPullRequest. So an Event Turn that reads a PR and then ends with noReply stores the note as a normal message with the card attached, and the Location gets it.

This affects any Event Turn that reads a PR or issue before it decides that nobody needs to know, for example PR maintenance on pull_request.checks.recovered.

Verified with an integration test through the conversation work harness and a plugin read tool that returns an object annotation:

  • Event Turn 1 calls the read tool, then noReply {note}: the note is stored as an assistant message with meta.objectCards and no meta.quiet.
  • Event Turn 2 calls only noReply {note}: the note is stored with meta.quiet: true.

via @dingsdax.

--

View Session [Sentry]

Activity

  1. changed the title [-]noReply notes from PR events are posted in the Slack thread[/-] [+]noReply note is posted when an Event Turn has a card[/+] on Nov 13, 2026
  2. changed the title [-]noReply note is posted when an Event Turn has a card[/-] [+]A read tool's card makes a noReply note visible[/+] on Nov 13, 2026
  3. added a commit that references this issue on Nov 13, 2026
    d2419dc
  4. sentry-junior commented on Nov 14, 2026

    @sentry-junior
    ContributorAuthor

    Fixed on main by #3433 (noReply posts nothing, so a pending card can no longer make the note visible) and #3437 (read-only tools no longer return Annotations). #3360 is closed as superseded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions