Repository navigation
feat(incidents): Collect postmortem meeting attendees by reaction - #455
Open
sentry-junior[bot] wants to merge 8 commits into
Open
sentry-junior[bot] wants to merge 8 commits into
sentry-junior[bot] wants to merge 8 commits into
Conversation
Co-Authored-By: Richard Gibert <richard.gibert@sentry.io>
Co-Authored-By: Richard Gibert <richard.gibert@sentry.io>
Co-Authored-By: Richard Gibert <richard.gibert@sentry.io>
Co-Authored-By: Richard Gibert <richard.gibert@sentry.io>
Co-Authored-By: Richard Gibert <richard.gibert@sentry.io>
…ents Private incidents should not post attendee prompts, schedule follow-ups, or invite and mention the scheduler bot, matching the existing triage-bot and statuspage reminder guards.
Rename MEETING_RECORDING to POSTMORTEM_MEETING_RECORDING instead of folding it into the meeting link, and store the scheduler bot's Meet link under a separate POSTMORTEM_MEETING_LINK type. Co-Authored-By: Richard Gibert <richard.gibert@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Richard:
Adds logic to get our triage bot (jr) to try to schedule a meeting by collecting interested parties then find an appropriate time slot.
Jr:
When a P0/P1 incident moves into Postmortem, Firetower now posts a message in the incident channel asking people to react if they want to be invited to the postmortem meeting. After a configurable window, it posts a follow-up that hands the reaction message off to a scheduler bot (e.g. Junior), which reads the reactions, schedules the meeting, and replies with the Google Meet link.
When the scheduler bot posts a message containing a Google Meet link in a Postmortem/Done incident's channel, Firetower saves it as the incident's new
POSTMORTEM_MEETING_LINKlink (shown as "Postmortem meeting"). A later link replaces the earlier one.The existing
MEETING_RECORDINGlink type stays separate and is renamed toPOSTMORTEM_MEETING_RECORDING(shown as "Postmortem meeting recording"). The migration moves existingMEETING_RECORDINGlinks over and reverses cleanly. API clients that writeexternal_links.meeting_recordingneed to switch topostmortem_meeting_recording.Firetower itself never reads reactions, so no new Slack scopes are needed; the meeting link is picked up from the
message.channels/message.groupsevents Firetower already receives. The follow-up is a one-off django-q schedule, same pattern as the statuspage reminders, and it's skipped if the incident has been reopened or canceled by the time it fires. Private incidents are skipped entirely (no prompt, schedule, or bot mention).New
[slack]config:postmortem_attendee_collection_days: how long to gather reactions after resolve. Unset disables the feature.postmortem_scheduler_bot_user_id: bot to invite and mention in the follow-up, and whose Meet links are recorded. Falls back totriage_bot_user_idwhen unset; with neither set, the prompt is posted without a mention and no links are recorded.postmortem_scheduler_bot_prompt: follow-up text, with{incident_number}and{prompt_url}placeholders. The default asks the bot to reply with the Google Meet link.Whether the scheduler bot responds to a mention posted by another bot (Firetower) hasn't been verified yet. That should be checked when this is first deployed.
via Richard Gibert.
--
View Junior Session [Sentry]