Skip to content

feat: propagate release workspaces - #872

Draft
BYK wants to merge 2 commits into
masterfrom
feat/workspace-action-propagation
Draft

feat: propagate release workspaces#872
BYK wants to merge 2 commits into
masterfrom
feat/workspace-action-propagation

Conversation

@BYK

@BYK BYK commented Aug 26, 2026

Copy link
Copy Markdown
Member

Summary

  • Accept and validate workspace input before every action side effect.
  • Pass the selected workspace through prepare, target discovery, publish issue identity, and controller execution.
  • Preserve legacy unscoped publish issue titles and use controller checkout identity only for secure state lookup.

Validation

  • pnpm test: 60 files, 1,138 passed, 1 skipped.
  • pnpm lint: 0 errors; 7 existing unused-variable warnings.
  • Prettier check and build passed.
  • Independent adversarial review: MERGE.

Dependency

Draft until getsentry/publish#9339 deploys. The Publish controller must accept workspace-qualified titles and provide the secure state-file contract before this action emits them.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1

QR code for preview link

馃殌 View preview at
https://craft.sentry.dev/pr-preview/pr-872/

Built to branch gh-pages at 2026-09-02 16:26 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

github:
owner: getsentry
repo: toolkit
workspaces:

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should allow defining workspaces with directory patterns like pnpm, npm, yarn etc allows

expect(() => validateConfiguration(data)).not.toThrow();
});

test('allows legacy workspace names', () => {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nobody uses "legacy workspace names" so we should just remove this support and associated tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant