feat(metrics): DLQ produce failures no increment a counter and log instead of panic. - #564
Merged
Merged
Conversation
…stead of panicking. Fix partition header bug.
phacops
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix DLQ producer panic + add observability for produce failures.
How
.expect()inKafkaDlqProducer::produce()withtracing::error!+arroyo.consumer.dlq.produce_errorcounterOther
original_partitionheader — was writing offset instead of partition indexWhy
MessageSizeTooLarge) panic, get caught by the JoinHandle, and silently drop the message. 1,467 occurrences on eap-items since May 29.tracing::error!surfaces as a Sentry issue via the sentry-tracing layer. Counter gives DD visibility.Links