Skip to content

fix: pass BASE_TEST_ENV to the coverage target #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vladch-outreach wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: pass BASE_TEST_ENV to the coverage target #1183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions root/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,8 @@ test-e2e:: pre-test
## coverage: generate code coverage
.PHONY: coverage
coverage:: pre-coverage
WITH_COVERAGE=true GOPROXY=$(GOPROXY) GOPRIVATE=$(GOPRIVATE) ./scripts/shell-wrapper.sh test.sh
go tool cover --html=/tmp/coverage.out
$(BASE_TEST_ENV) WITH_COVERAGE=true ./scripts/shell-wrapper.sh test.sh
go tool cover --html=/tmp/coverage.out

.PHONY: e2e
e2e:: pre-e2e
Expand Down