Repository navigation
fix(hud): open no camera preview window at launch while the camera is off - #1647
EtienneLescot wants to merge 1 commit into
Conversation
… off v2.3.0 created the floating camera preview window, transparent and content-protected, the moment the HUD mounted, camera on or off. It is the only new window macOS gets at launch since v2.2.2, where the same HUD with the same content protection paints. Create it only once the camera is on; the macOS capture paths still reserve it before they read exclusion IDs. Refs #1639
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Refs #1639
Why
On macOS 15.3.1, v2.3.0's HUD exists and renders but never paints; v2.2.2 paints with the same HUD window options and the same content protection. The HUD's main-process code did not change between the tags. The one new window macOS gets at launch is the floating camera preview: the HUD configures it on mount, camera on or off, and
CameraPreviewController.configurecreated it every time, transparent, always on top and content-protected, beside the HUD.OPENSCREEN_DISABLE_CONTENT_PROTECTION=1also lifts protection from that window, which fits the reporter's workaround.Change
configureno longer creates the preview window while the camera is off. It is created once the camera is turned on, as before. The macOS capture paths still reserve it before reading exclusion IDs (ensureMacCameraPreviewWindow), so exclusions and Apple-picker picks behave as before. Content protection stays on for every window.Not verified
Checks
npx vitest --run electron/cameraPreview.test.ts src/hooks/useFloatingCameraPreview.test.tsx, both typechecks, Biome. No rendering path touched: window lifetime only.🤖 Generated with Claude Code
Summary by CodeRabbit