Repository navigation
fix(capture): close an open pause before a Linux take's stopped snapshot - #1645
EtienneLescot wants to merge 1 commit into
Conversation
The helper can emit capture-stopped while the take is paused, before stop() runs. That snapshot was compacted with the completed pause ranges only, so cursor samples from the open pause stayed in the take, past the video's end. Both snapshot paths now close the open pause first, at the helper's stop timestamp when it gives one. Refs #1637
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Refs #1637
Thanks @fernandezbaptiste for the clear report and the exact event sequence.
What changed
capture-stoppedwhile the take is paused, before the app callsstop(). That snapshot was compacted with the completed pause ranges only, so cursor samples from the open pause stayed in the take, past the video's end.capture-stoppedand the interrupted-take salvage) now go through onestoppedCursorData(), which closes the open pause first, at the helper's stop timestamp when it gives one.Tests
capture-stopped1500 (200 ms),stop()1600 → samples[100]. It fails onmainwith[100, 300].linuxNativeCaptureSession.test.ts46/46, both typechecks, lint clean.Scope
Pause and stop bookkeeping of cursor telemetry only. No change to frame capture, encoding, compositing or export timing.
🤖 Generated with Claude Code
Summary by CodeRabbit