Repository navigation
fix(mcp): report a failed recording start's reason instead of a 30s timeout - #1641
Conversation
The start funnel caught every failure, showed its toast and resolved normally, so a caller could only learn of a failed start from recording state that never flips. startRecording now answers with an outcome: started, cancelled, or failed with the message the toast showed. The countdown and restart paths ignore it as before.
A start the recorder had already failed left the hidden runner guessing: its deadline answered MCP startRecording and `openscreen record` with "Recording did not start within 30s — see stderr". The runner now fails at once with the outcome's reason, says when the picker was dismissed, and appends the system-cursor retry advice only to the cursor-metadata failure. The deadline remains only as a backstop for a start that reports success but never confirms; in a race with the camera effect (getopenscreen#1303) the first error still wins.
FakeRunners can now name a record start's failure. Assert the startRecording tool error carries that reason, so the forwarding above the runner stays honest.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Summary
startRecording(stdio MCP) andopenscreen recordnow fail immediately when the recorder already knows its start failed, returning the recorder's reason instead of "Recording did not start within 30s — see stderr".startRecordinganswers with an outcome — started, cancelled, or failed with the message its toast already showed. GUI behavior unchanged; countdown and restart ignore it.Retry with "cursor": "system" …only to the cursor-metadata failure, matched on the helper's typed wording so it cannot misfire.Related issue
Fixes #1640
Type of change
Release impact
Desktop impact
Screenshots / video
None — no UI change.
Summary by CodeRabbit