Skip to content

align attributes and report env#192

Merged
jay-418 merged 9 commits intomainfrom
jay/semconv
Apr 2, 2026
Merged

align attributes and report env#192
jay-418 merged 9 commits intomainfrom
jay/semconv

Conversation

@jay-418
Copy link
Copy Markdown
Contributor

@jay-418 jay-418 commented Mar 21, 2026

@jay-418 jay-418 marked this pull request as ready for review March 27, 2026 04:06
Copilot AI review requested due to automatic review settings March 27, 2026 04:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Lantern Box telemetry to use the shared github.com/getlantern/semconv attribute set and adds build/version reporting to OTEL resources (relates to engineering issue #3035).

Changes:

  • Replaces direct OpenTelemetry semconv usage with github.com/getlantern/semconv in tracker + otel packages.
  • Enriches proxy connection metrics/spans with additional semantic attributes (including client info).
  • Adds service.version to the OTEL resource using VCS build metadata.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tracker/metrics/tracker.go Switches to shared semconv keys and adds client-info enrichment to metric attributes and correlation span attributes.
otel/otel.go Uses shared semconv and adds service.version derived from build info to the OTEL resource.
otel/otel_test.go Updates semconv import to shared module for resource attribute assertions.
go.mod Bumps github.com/getlantern/semconv and updates some OTel module versions.
go.sum Updates checksums for bumped dependencies.
AGENTS.md Documents repository guidance to follow shared semconv rules for telemetry attributes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@reflog reflog self-requested a review March 27, 2026 15:35
Copy link
Copy Markdown
Collaborator

@reflog reflog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jay-418 in general - ok. but can you comment on the cardinality issue that copilot picked up?

@jay-418
Copy link
Copy Markdown
Contributor Author

jay-418 commented Apr 1, 2026

@jay-418 in general - ok. but can you comment on the cardinality issue that copilot picked up?

@reflog I've refactored some, but for the cardinality aspect:

  • sing.connections and sing.connetion_duration have had device_id removed
  • proxy.io has kept device_id, because I think we need that data for business needs, if not operational, right?

@jay-418 jay-418 requested a review from reflog April 1, 2026 04:36
@jay-418 jay-418 merged commit 77f9515 into main Apr 2, 2026
3 checks passed
@jay-418 jay-418 deleted the jay/semconv branch April 2, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants