Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Lantern Box telemetry to use the shared github.com/getlantern/semconv attribute set and adds build/version reporting to OTEL resources (relates to engineering issue #3035).
Changes:
- Replaces direct OpenTelemetry semconv usage with
github.com/getlantern/semconvin tracker + otel packages. - Enriches proxy connection metrics/spans with additional semantic attributes (including client info).
- Adds
service.versionto the OTEL resource using VCS build metadata.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
tracker/metrics/tracker.go |
Switches to shared semconv keys and adds client-info enrichment to metric attributes and correlation span attributes. |
otel/otel.go |
Uses shared semconv and adds service.version derived from build info to the OTEL resource. |
otel/otel_test.go |
Updates semconv import to shared module for resource attribute assertions. |
go.mod |
Bumps github.com/getlantern/semconv and updates some OTel module versions. |
go.sum |
Updates checksums for bumped dependencies. |
AGENTS.md |
Documents repository guidance to follow shared semconv rules for telemetry attributes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
reflog
approved these changes
Mar 27, 2026
Contributor
Author
@reflog I've refactored some, but for the cardinality aspect:
|
reflog
approved these changes
Apr 1, 2026
garmr-ulfr
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to https://github.com/getlantern/engineering/issues/3035