Skip to content

fix: tooltip options on top of selections#321

Merged
iparaskev merged 2 commits into
mainfrom
fix_shortcut_view_after_list_open
May 28, 2026
Merged

fix: tooltip options on top of selections#321
iparaskev merged 2 commits into
mainfrom
fix_shortcut_view_after_list_open

Conversation

@iparaskev
Copy link
Copy Markdown
Contributor

@iparaskev iparaskev commented May 28, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Tooltips for microphone and camera controls now behave consistently around device selection menus, preventing flicker or unexpected opens/closes when interacting with dropdowns.
    • Opening device selection menus now refreshes the device lists and reliably suppresses tooltip interactions while the menu is open, ensuring accurate and stable device switching.

Review Change Stack

@iparaskev iparaskev requested a review from konsalex as a code owner May 28, 2026 07:49
@netlify
Copy link
Copy Markdown

netlify Bot commented May 28, 2026

Deploy Preview for hoppdocs ready!

Name Link
🔨 Latest commit 3e2d1d6
🔍 Latest deploy log https://app.netlify.com/projects/hoppdocs/deploys/6a17f984562b9b0008321b88
😎 Deploy Preview https://deploy-preview-321--hoppdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 035f7af2-9fc1-48ee-89c0-c589d0089281

📥 Commits

Reviewing files that changed from the base of the PR and between 303e38b and 3e2d1d6.

📒 Files selected for processing (1)
  • tauri/src/components/ui/call-center.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • tauri/src/components/ui/call-center.tsx

📝 Walkthrough

Walkthrough

The call center UI component now coordinates tooltip visibility with device-selection dropdown state in both microphone and camera controls. Tooltips are controlled by new local state and only update when the dropdown is not active, preventing tooltip churn while users interact with the device selection menus.

Changes

Tooltip and dropdown coordination in call center controls

Layer / File(s) Summary
Microphone dropdown and tooltip coordination
tauri/src/components/ui/call-center.tsx
Microphone control adds local state (tooltipOpen, selectOpen) and suppressTooltipRef, a guarded handleTooltipOpenChange to ignore tooltip changes while the selector is active, updates the selector onOpenChange to sync selectOpen, force-close the tooltip, manage suppression, and refetch microphones, and converts the wrapping Tooltip to controlled mode.
Camera dropdown and tooltip coordination
tauri/src/components/ui/call-center.tsx
Camera control applies the same pattern: local state for tooltip and selector tracking, a guarded handleTooltipOpenChange that ignores tooltip events during selector interaction, an onOpenChange that closes the tooltip and triggers refetchCameras when opened, and switching the Tooltip to controlled mode.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • konsalex

Poem

I’m a rabbit with a tiny dev hat, 🐰
I guard the tooltips — soft and flat.
When selectors open, I hush the chime,
So mics and cams stay calm in time.
A hop, a fix, UI kept neat. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main fix: preventing tooltips from appearing on top of dropdown selections by converting them to controlled components.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix_shortcut_view_after_list_open

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@iparaskev iparaskev merged commit c269c83 into main May 28, 2026
18 checks passed
@iparaskev iparaskev deleted the fix_shortcut_view_after_list_open branch May 28, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants