Skip to content

fix: fix custom url out of sync#320

Merged
iparaskev merged 1 commit into
mainfrom
fix_link_update
May 27, 2026
Merged

fix: fix custom url out of sync#320
iparaskev merged 1 commit into
mainfrom
fix_link_update

Conversation

@iparaskev
Copy link
Copy Markdown
Contributor

@iparaskev iparaskev commented May 27, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Custom backend URL now persists when resetting application settings
    • Custom backend URL is properly synced when modified in settings

Review Change Stack

@iparaskev iparaskev requested a review from konsalex as a code owner May 27, 2026 17:19
@netlify
Copy link
Copy Markdown

netlify Bot commented May 27, 2026

Deploy Preview for hoppdocs ready!

Name Link
🔨 Latest commit ac911fd
🔍 Latest deploy log https://app.netlify.com/projects/hoppdocs/deploys/6a1727bec2bdd600099aafbe
😎 Deploy Preview https://deploy-preview-320--hoppdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 909cd16f-7c7b-47f7-84d3-e1aa3bd8a6b4

📥 Commits

Reviewing files that changed from the base of the PR and between 2884ae4 and ac911fd.

📒 Files selected for processing (2)
  • tauri/src/store/store.ts
  • tauri/src/windows/settings/main.tsx

📝 Walkthrough

Walkthrough

This PR ensures the custom server URL persists across application state resets. The store's reset action is updated to preserve customServerUrl instead of clearing it via initialState, and the settings UI input handlers are wired to synchronize URL changes with the global store.

Changes

Custom Server URL Persistence Across Store Resets

Layer / File(s) Summary
Store reset preservation logic
tauri/src/store/store.ts
The reset action captures customServerUrl before applying initialState, then restores it afterward, ensuring the URL is not cleared during application state resets.
Settings UI integration
tauri/src/windows/settings/main.tsx
The settings component imports useStore and updates the global store via setCustomServerUrl(trimmed) when the custom backend URL input is committed (Enter key) or loses focus (onBlur), synchronized with the existing Tauri backend update flow.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 The URL remembers its home,
Through resets it won't roam,
Settings now sync with the store,
Preserving custom server lore! 🌐

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: fixing custom URL synchronization issues across store resets and UI updates.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix_link_update

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@iparaskev iparaskev merged commit 4a3e53e into main May 27, 2026
18 checks passed
@iparaskev iparaskev deleted the fix_link_update branch May 27, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant