fix(programs): white-label tenants can't create campaigns (shareOnNetwork default)#42
Merged
Merged
Conversation
…nblocks campaign creation Real-world blocker (first white-label customer): defaultShareOnNetwork returns the Network membership flag, which white-label tenants still have (the row is deliberately retained for the road back) — so campaign creation defaulted shareOnNetwork=true, then 400'd requiring a marketplace description for a surface their UI correctly hides. Every formerly-federated white-label brand was fully unable to create campaigns. - defaultShareOnNetwork: false when white-label is effective - POST /programs: force false (even explicit true) before the description requirement - PATCH /programs/:id: pin false on every edit — also normalizes pre-white-label rows still carrying true, so a lapsed add-on can't resurrect a stale listing Belt-and-suspenders with the existing sync guard (which made the flag inert at publish time but not at validation time — validation is where it hurt). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete campaign-creation blocker for formerly-federated white-label brands, reported by xispark with exact repro.
defaultShareOnNetworkreturns the Network membership flag — which white-label tenants still carry (deliberately retained for restoration) — soPOST /programsdefaultedshareOnNetwork=trueand then 400'd demanding amarketplaceDescription… for a marketplace surface the white-label UI correctly hides. No UI path could satisfy or bypass it.defaultShareOnNetwork→ false when white-label is effectivePOST /programs→ force false (even explicittrue) before the description requirementPATCH /programs/:id→ pin false on every edit (also normalizes pre-white-label rows still carryingtrue)The existing marketplace-sync guard made the flag inert at publish time; validation time is where it actually bit. Suite green 192/192.
🤖 Generated with Claude Code