docs(workflow): x-flow-wait directive + audit follow-ups#24
Open
docs(workflow): x-flow-wait directive + audit follow-ups#24
Conversation
Adds a parallel directive section for x-flow-wait next to the existing x-flow-condition section, covering the rendered DOM, node.data shape, duration formatting, and pairing with flow-wait workflow nodes. Also commits the repo-internal CLAUDE.md (tech stack, build/test commands, branching rules), adds five error-path tests for the flow-condition directive (invalid _branchTaken, malformed condition, garbage direction expressions), and clarifies the cached-at-init assumption in the schema inspector's findCanvasScope() with a forward reference to the workflow addon's ensureCanvas pattern. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audit follow-ups from the post-Phase-1+2 sweep across alpineflow / wireflow / artisanflow.
x-flow-waitdirective section todocs/addons/workflow.md, parallel to the existingx-flow-conditiondirective section. Covers the rendered DOM, thenode.datashape, the duration-format table, and the pairing withflow-waitworkflow nodes.CLAUDE.md(tech stack, build/test commands, addon layout, theming rules, branching rules) for human and AI contributors working inside the package.x-flow-conditiondirective: invalid_branchTakenvalues are not reflected, malformedconditionshapes render an empty body, garbage direction expressions fall back to'horizontal'.findCanvasScope()(src/schema/inspector/shared.ts) with a forward reference to the workflow addon'sensureCanvaspattern, so a future contributor placing inspectors in portals or tab-switched panels knows to mirror that fix.No source-behavior changes — docs, tests, and an internal JSDoc note only.
Test plan
npm run test— 2582/2582 pass (the two pre-existing flow-schema test warnings are unchanged fromdev)npx tsc --noEmit— cleanx-flow-waitdoc section renders correctly in the markdown