fix(menubar): drop ' tok' suffix from Total Tokens metric (#497)#511
Merged
Conversation
Per #497 feedback: with Total Tokens selected the bar showed e.g. '0 tok'. The user picked the metric, so the unit is redundant; show just the number (the flame already disambiguates it from cost). Compact mode already had no suffix; this only changes the wide rendering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from #497: with the Total Tokens metric selected, the menu bar showed e.g.
🔥 0 tok. The reporter asked to drop thetokunit — the user explicitly chose the metric, and the flame already disambiguates it from a dollar amount.Change: the wide rendering now shows
<total><periodSuffix>instead of<total> tok<periodSuffix>. Compact mode already had no unit. The Credits metric keeps itscr/creditsmarker (it would otherwise be indistinguishable from total tokens).swift buildpasses.