Improve built-in terminal reliability and remote replay performance - #1076
Open
Diffuzmetall wants to merge 1 commit into
Open
Improve built-in terminal reliability and remote replay performance#1076Diffuzmetall wants to merge 1 commit into
Diffuzmetall wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1075.
Summary
Measurements
Sustained output
A local 16 MiB output probe improved from about 6.5 MiB/s to 53–63 MiB/s. Websocket output messages dropped from 16,386 to 258–480 depending on PTY chunking.
Input remained responsive during a 16 MiB remote flood. Over the Tailscale path used for QA, the full burst completed without disconnect while a concurrent input echo returned in 101 ms.
Reopening a populated remote terminal
Measured through an SSH tunnel to a patched VPS:
A subsequent reconnect requested the previous
nextSeqand replayed only 319 bytes rather than the retained history.Input integrity
A 200,009-byte payload containing emoji and combining characters crossed multiple 64 KiB request boundaries on the VPS with an exact SHA-256 match. CLI
--stdinalso has coverage for invalid UTF-8 bytes.Validation
On current
main:pnpm exec turbo run typecheckfor app, CLI, host daemon, host-daemon contract, server, SDK, server contract, and templates