Fix: Omit hidden input before checkbox group#314
Open
ftes wants to merge 3 commits into
Open
Conversation
22300cc to
462f68f
Compare
ftes
commented
Apr 29, 2026
ftes
commented
Apr 29, 2026
| nil -> | ||
| data ++ new_entries | ||
|
|
||
| first_index -> |
Contributor
Author
There was a problem hiding this comment.
This is a bit of a crux to handle multiple fields with same name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Omit hidden 'reset' input that appears before checkbox group if any checkboxes are checked.
What changed?
Why make these changes?
A hidden input before a checkbox group can be used to reset the value if all checkboxes are unchecked.
However, if checkboxes are checked, then the hidden input should be effectively ignored.
Plug/Phoenix can handle this if the field values arrive in DOM order.
In forms like:
PhoenixTest previously collected controls by selector category and stored
FormDatain a map. That lost DOM order and collapsed repeated field names, which could cause the hidden scalar entry to interfere with the checkbox array payload.This PR is only a partial improvement. The ideal solution would be to submit form data in the exact DOM order a browser would, end to end.