[codex] Remove project script port defaults#131
Draft
germanescobar wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLIENT_BASE_PORT=4500andAPI_BASE_PORT=3100into project script environments.controller-scriptsguidance so project scripts define their own base ports and only use Controller'sPORT_OFFSETfor isolation.Root Cause
Controller was treating its own app defaults as generic project script defaults. Projects that consumed those env vars could accidentally start services on Controller's ports when the Run button executed their scripts.
Validation
npm test -- server/lib/__tests__/project-scripts.test.tsbash -n .coding-orchestrator/setup.sh && bash -n .coding-orchestrator/run.shin/Users/germanescobar/Projects/pocs/market-trends