Fix flaky sealed-frame assertion in session test - #155
Merged
Merged
Conversation
A header-sealed frame's first byte is a random nonce byte, so assert_ne!(welcome_b.first(), Some(&APQ_TAG)) had a 1/256 chance of matching the plaintext tag and failing CI. Replace it with a deterministic check that the plaintext welcome doesn't appear in the sealed frame, mirroring the envelope check earlier in the same test. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 42f2d4a The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_initial_envelope_roundtrip_return_welcome_sealedcheckedassert_ne!(welcome_b.first(), Some(\&APQ_TAG))on a header-sealed frame. The first byte of a sealed frame is a random nonce byte, so it matchesAPQ_TAG(0x01) about 1 in 256 runs — this flaked CI on an unrelated PR.Replaced with a deterministic check that the plaintext welcome doesn't appear in the sealed frame, mirroring the envelope check earlier in the same test. Scanned the rest of
tests.rsfor similar patterns; the otherassert_ne!(...first()...)checks are on the HPKE envelope, whose leading bytes are a fixed length prefix (deterministic), so left those alone.Added an empty changeset since this is test-only.
Test notes: ran the fixed test 1000x in a loop locally with zero failures. Also ran
cargo fmt --all -- --check,taplo fmt --check, both clippy gates, andcargo test -p two-mls-pq --features cryptokit(all pass).🤖 Generated with Claude Code