Specify MLSMessage framing for draft-02 pair elements - #153
Merged
Merged
Conversation
The book was silent on whether the welcome halves and return key package are bare structs or MLSMessages. The deployed engine emits and requires MLSMessages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 30d8dcb The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The spec states intended behavior, so justify the envelope on RFC terms, and record in the draft-02 conformance section that every APQWelcome and APQKeyPackage element travels as an MLSMessage. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
germ-mark
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft-02 §7 declares
APQWelcomeandAPQKeyPackagewith bareWelcomeandKeyPackagefields. It doesn't say how those structures are transmitted. Germ carries each element in its RFC 9420MLSMessageenvelope (mls_welcome/mls_key_package), which describes its own protocol version and content type. The book was silent on this. This PR:APQWelcomehalf in the reply'swelcomesection, and thereturn_key_package, areMLSMessages.MLSMessage: both halves of the[v=3]combiner key package, each half of everyAPQWelcome, and the return key package.This is Germ's choice of transport envelope, not a shipped anomaly. Both engines' encoders already agree with it:
encode_combiner_key_packageandpublishedBlob();create_group_with_memberandjoin_group_from_welcome;parse_mls_key_package.Book-only, with an empty changeset.
🤖 Generated with Claude Code