Conversation
With TwoMLSPQBinding in two products, Xcode can link a second binding copy into one process, and a callback through it aborts on a stale handle. Removes the TwoMLSPQMigrate product. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 9072ceb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
germ-mark
marked this pull request as draft
September 24, 2026 20:48
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #147 and meant to ship in the same release.
The
TwoMLSPQMigrateproduct is removed. Its module now ships in theTwoMLSPQproduct. This is breaking: consumers swap.product(name: "TwoMLSPQMigrate")for.product(name: "TwoMLSPQ"). Imports are unchanged.Why: the internal
TwoMLSPQBindingtarget sat in both products, and Xcode avoids duplicate code per product, not per target. In an Xcode test build,TwoMLSPQbecame a shared framework holding one binding copy, whileTwoMLSPQMigratelinked statically into the test bundle with a second copy. Each copy keeps its own callback handle map, but Rust keeps a single callback vtable. So a sink installed through one copy is looked up in the other copy's map, and the process aborts with "Callback interface failure" (unexpectedStaleHandle).Tests
xcodebuild: a dynamic framework linkingTwoMLSPQ, plus a test bundle linking the TwoMLSPQ products.TwoMLSPQBindingas a separate product doesn't help; the abort still reproduces.swift test(local xcframework) passes 98 XCTest and 19 Swift Testing tests, and swift-format strict is clean.🤖 Generated with Claude Code