Use Java 21 to build and run proxy, add a main entrypoint and a docker image#82
Open
f-necas wants to merge 6 commits into
Open
Use Java 21 to build and run proxy, add a main entrypoint and a docker image#82f-necas wants to merge 6 commits into
f-necas wants to merge 6 commits into
Conversation
Collaborator
|
@f-necas could you please also set JDK 21 in the CI scripts? |
f-necas
force-pushed
the
update-and-add-docker-image
branch
from
bfdefcf to
f1c018e
Compare
Contributor
Author
Collaborator
|
@f-necas We've decided to keep Java 17 as the minimum supported version for now, so could you please update the PR accordingly and switch the baseline from Java 21 back to Java 17? Sorry for the change in direction. Thanks again for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
CI is failing cause of java version use in repo's workflow. We could also set java 17 for minimal version