#12467 Add maximum visible features in current view option for FlatGeobuf layers (Implement Design Change Feedback)#12552
Open
Binabh wants to merge 2 commits into
Conversation
6 tasks
Binabh
changed the title
Binabh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Design change to use tooltip instead of placeholder as clarification text is too long.
Feedback here
Also added test to ensure that tooltip is there and updated translation keys for better clarity.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#12467 (comment)
What is the new behavior?
Uses tooltip instead of placeholder
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)