Skip to content

Rework docker compose for swarm support#377

Open
jeanmi151 wants to merge 9 commits into
masterfrom
rework_compose
Open

Rework docker compose for swarm support#377
jeanmi151 wants to merge 9 commits into
masterfrom
rework_compose

Conversation

@jeanmi151
Copy link
Copy Markdown
Contributor

This is a rework of docker compose for swarm support

Copy link
Copy Markdown
Member

@jeanpommier jeanpommier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, quick review.

Before any remarks, this is really interesting work, thanks a lot for the contribution !

Apps

Apps started but not available on the interface:

  • metadata-editor. Not routed in GW. /etc/georchestra/metadata-editor does not exist in config

Apps not configured

  • smtp (documented ?)
  • geonetwork (as before afaik, but would be good to give a kickoff hint)
  • datahub shows error due to GN not initialized

Documentation

Readme

  • tells the user to rsync on port 2222. Relies on ssh_data container, removed from the compo
  • SMTP service references the old behaviour (trapped into local sink), while this offers an SMTP relay, to be configured (document how to)
  • double paragraphs about kibana

Running as docker compose

Seems fine, apart from previously mentioned points

Running as docker swarm

On first deploy, some services fail before they're restarted and their dependencies are fulfilled. Maybe worth mentioning it, so that the users wait for them to settle

Cleaning the volumes

I noticed it is not really straightforward to clean the volumes afterwards. Maybe a quick instruction on how to do it would help. Either for classic cleanup after having given swarm a try. Or because you need to start fresh for whatever reason.
It came out with something that might not be perfect:

STACK_NAME=georchestra
for vol in `docker volume ls --filter "Name=${STACK_NAME}_.*" --format json | jq -r '.Name'`; do docker volume rm $vol ; done

Comment thread README.md Outdated
Comment thread README.md Outdated
Emails sent by the SDI (eg when users request a new password) will not be relayed on the internet but trapped by a local SMTP service.
These emails can be read on https://georchestra-127-0-0-1.nip.io/webmail/ (with login `smtp` and password `smtp`).

Emails sent by the SDI (eg when users request a new password) will not be relayed on the internet but trapped by a local SMTP service.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ? Trapped ? AFAIK, with the new config, we have an smtp relay, that will not really work since it's not configured by default.
=> tell folks to configure the SMTP relay and modify accordingly this line ?
Does it mean we drop the old SMTP sink stuff ? (not against it, since it was really demo-mode only, but asking anyway)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"trapped by a local SMTP service." is not true anymore, or is it ?

@jeanmi151
Copy link
Copy Markdown
Contributor Author

thanks @jeanpommier for your tests,

I created a pr to add metadata-editor in the datadir georchestra/datadir#502

And I took into account you remark about the README

Comment thread docker-compose.yml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants