Open
Conversation
effect a reversal. The additional nodes are called 'loopback nodes' and they serve to make the layout engine exit the original source node on the right and enter the original target node on the left.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My take on how cycles can be addressed in the viewer (both for circular DNA and convoluted GFAs from genome assemblies).
To help with testing it includes snapshots on the DNA level too, corresponding to the existing tests, and it's easy to add more. These are all part of the views folder, so when that gets broken out, the snapshot tests come along.
The way GFA import cycle breaking works in different cases is something to be discussed, but out of scope here.
I squashed into logical commits. One of them hits a lot of files because I had to change the ownership model of GraphController at one point. There may still be some outstanding viewer chores to go, but this PR should not impede that.