Repository navigation
docs(kb): drop the redundant numerals in the Arabic example - #605
Closed
Kevin-Liu-01 wants to merge 2 commits into
Closed
Kevin-Liu-01 wants to merge 2 commits into
Kevin-Liu-01 wants to merge 2 commits into
Conversation
The Arabic example wrote "1 شخص يشاهد" and "2 شخصان يشاهدان". The singular and dual forms already carry the count, and CLDR writes the Arabic one and two forms without a number (ICU 77.1 with CLDR 47 gives يوم and يومان for one and two days). The two lines now drop the digit, and the few and many lines keep theirs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
8 tasks done
Resolved conflicts in kb/en-US/how-to-handle-plurals-in-react.mdx (moved from kb/ on main; the edit applies next to main's text fence). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Covered by #650 (merged): the revised plurals article no longer has the Arabic example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Arabic example in the KB article "How do I handle plurals in React?" (
kb/how-to-handle-plurals-in-react.mdx:178-184) puts a numeral before the singular and dual forms: "1 شخص يشاهد" and "2 شخصان يشاهدان". In Arabic the singular noun already means one and the dual (شخصان) already means two, so the digit repeats the count. The article's point is that each language's plural forms differ, so its own example should follow them.CLDR writes the Arabic
oneandtwoforms without a number. With ICU 77.1 and CLDR 47 (Node.js 24.13.0),Intl.NumberFormat('ar', { style: 'unit', unit: 'day', unitDisplay: 'long' })gives:The hour unit gives the same pattern (ساعة, ساعتان, 3 ساعات, 11 ساعة).
Changes
kb/how-to-handle-plurals-in-react.mdx: "1 شخص يشاهد" becomes "شخص يشاهد" and "2 شخصان يشاهدان" becomes "شخصان يشاهدان". The zero, few (3) and many (11) lines are unchanged.Size: 1 file, +2/-2.
Test plan
Intl.PluralRules('ar')for 0, 1, 2, 3 and 11 (zero, one, two, few, many).Run on this branch (
k/docs-kb-plurals-arabicat 2396716, on origin/main f93de7c), inscripts/afternpm ci:validate-links: all links validvalidate:unsafe-htmlandvalidate:callouts: 546 MDX files each, cleanvalidate:reference-links: 500 MDX files against 301 reference symbol aliases, cleanvalidate:structure,validate:blog-orderandvalidate:kb(5 articles): cleantest: 7 scripts, 155 cases passedtypecheck: cleanjavascript:URLs in MDX finds nothing, and the changed article parses with the MDX parser the validators use.Open PRs #595 and #597 edit this article. Both merge cleanly with this branch (
git merge-tree), and so does #606 (k/docs-kb-plurals-fence).Note
The docs research report asked for a native Arabic speaker to approve the wording before this change. This branch follows the CLDR forms. It is kept apart from the fence fix so that the fence fix can merge whatever the review decides.
🤖 Generated with Claude Code