Repository navigation
docs(kb): describe when Locadex runs in the tooling article - #604
Closed
Kevin-Liu-01 wants to merge 1 commit into
Closed
Kevin-Liu-01 wants to merge 1 commit into
Kevin-Liu-01 wants to merge 1 commit into
Conversation
"What is the best localization software for developers?" said Locadex opens pull requests on every push. New Generate code and Generate translations and push automations run when a pull request is opened, and running on every push is a trigger the team chooses. Both mentions now describe the default and link the trigger setting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Covered by #650 (merged): it rewrote the tooling article's text about when Locadex runs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
The KB article "What is the best localization software for developers?" says twice that Locadex runs on every push: it "opens pull requests on every push" (
kb/best-localization-software.mdx:29), and in step 4, "When you push code, it scans for changes ... and opens a PR" (:80). That is not the default. New Generate code and Generate translations and push automations run when a pull request changes, and a run on every push is the A commit is pushed trigger, which the team chooses.platform/locadex/guides/configuring-automations.mdx:41-47: A pull request changes runs when a relevant pull request is opened, reopened or marked ready for review. A commit is pushed runs on pushes to the target branch. The two templates default to A pull request changes.origin/main(d633468),apps/dashboard/src/lib/locadex/workflowPresetDefaults.ts:12:trigger: settingsType === 'UPDATE_LOCALES' ? 'MANUAL' : 'PULL_REQUEST'.Changes
kb/best-localization-software.mdx:configuring-automations#configure-automation).Size: 1 file, +2/-2.
Test plan
Run on this branch (
k/docs-kb-locadex-triggerat 843b6bb, on origin/main f93de7c), inscripts/afternpm ci:validate-links: all links valid, including the new anchorvalidate:unsafe-htmlandvalidate:callouts: 546 MDX files each, cleanvalidate:reference-links: 500 MDX files against 301 reference symbol aliases, cleanvalidate:structure,validate:blog-orderandvalidate:kb(5 articles): cleantest: 7 scripts, 155 cases passedtypecheck: cleanjavascript:URLs in MDX finds nothing, and the changed article parses with the MDX parser the validators use.Open PRs #595 (publish dates) and #597 (step 3, "Sub-50ms") edit this article. Both merge cleanly with this branch (
git merge-tree).🤖 Generated with Claude Code