Skip to content

fix(webdriver): do not retry timeouts for "response" event #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DudaGod merged 1 commit into from
May 13, 2026
Merged

fix(webdriver): do not retry timeouts for "response" event #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/webdriver/src/request/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export class RequestLibError extends Error {
statusCode?: number
body?: unknown
code?: string
event?: string
}

export const COMMANDS_WITHOUT_RETRY = [
Expand Down Expand Up @@ -219,6 +220,13 @@ export default abstract class WebDriverRequest extends EventEmitter {
if ((response as RequestLibError).code === 'ETIMEDOUT') {
const error = getTimeoutError(response, fullRequestOptions)

if ((response as RequestLibError).event === 'response') {
log.debug('Request timed out waiting for server response - not retrying')
this.emit('response', { error })
this.emit('performance', { request: fullRequestOptions, durationMillisecond, success: false, error, retryCount })
throw error
}

return retry(error, 'Request timed out! Consider increasing the "connectionRetryTimeout" option.')
}

Expand Down
Loading