This repository was archived by the owner on Sep 21, 2022. It is now read-only.
feat(*): add system/testFormats option to config#733
Open
tx44 wants to merge 1 commit intogemini-testing:masterfrom
Open
feat(*): add system/testFormats option to config#733tx44 wants to merge 1 commit intogemini-testing:masterfrom
tx44 wants to merge 1 commit intogemini-testing:masterfrom
Conversation
j0tunn
suggested changes
May 12, 2017
Contributor
j0tunn
left a comment
j0tunn
left a comment
There was a problem hiding this comment.
Sorry for long delay.
Can you also fix tests?
| .build({ | ||
| root: config.system.projectRoot, | ||
| formats: config.system.testFormats | ||
| }, {ignore: config.system.exclude}) |
Contributor
There was a problem hiding this comment.
Lets pass all this options via single object:
.build({
root: config.system.projectRoot,
formats: config.system.fileExtensions,
globOpts: {
ignore: config.system.exclude
}
})| * `testFormats` - array of filename extensions for tests to proceed. `.js` is available by default, override this if you want: | ||
|
|
||
| ```yaml | ||
| testFormats: |
Contributor
There was a problem hiding this comment.
lets rename testFormats to fileExtensions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For using not only .js extensions in tests.
gemini-testing/gemini-core#5
researchgate/gemini-react#28