This repository was archived by the owner on Sep 21, 2022. It is now read-only.
Changed require configuration to path relative to current working dir…#427
Open
BigBadAlien wants to merge 1 commit intogemini-testing:masterfrom
Open
Changed require configuration to path relative to current working dir…#427BigBadAlien wants to merge 1 commit intogemini-testing:masterfrom
BigBadAlien wants to merge 1 commit intogemini-testing:masterfrom
Conversation
BigBadAlien
force-pushed
the
js_json_configuration_relative_path
branch
from
9879fe3 to
8e6bf55
Compare
…ectory For example working directory is `/home/foo/project_with_gemini/gemini/`. We use js or json default path configuration or use `-c` option. Run `./gemini` or `./gemini -c .very_special_configuration.json`. And we get configuration relative to current working directory: /home/foo/project_with_gemini/gemini/.gemini.conf.json /home/foo/project_with_gemini/gemini/.gemini.conf.js /home/foo/project_with_gemini/gemini/.very_special_configuration.json not in directory anywhere in the node_modules. Fixed gemini-testing#418.
BigBadAlien
force-pushed
the
js_json_configuration_relative_path
branch
from
8e6bf55 to
a4fd607
Compare
Author
|
Functional and unit tests in summary covers all added code. |
Contributor
|
/cc @Cody0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ectory
For example working directory is
/home/foo/project_with_gemini/gemini/.We use js or json default path configuration or use
-coption.Run
./geminior./gemini -c .very_special_configuration.json.And we get configuration relative to current working directory:
/home/foo/project_with_gemini/gemini/.gemini.conf.json
/home/foo/project_with_gemini/gemini/.gemini.conf.js
/home/foo/project_with_gemini/gemini/.very_special_configuration.json
not in directory anywhere in the node_modules.
Fixed #418.