Add GC_GUARD's for encoding converted strings sent to the server#706
Open
larskanis wants to merge 1 commit into
Open
Add GC_GUARD's for encoding converted strings sent to the server#706larskanis wants to merge 1 commit into
larskanis wants to merge 1 commit into
Conversation
The intermediate String object wasn't stored, so that the underlying memory could be free'd before the C string was processed. Fixes #705
ged
approved these changes
Jun 2, 2026
Owner
ged
left a comment
ged
left a comment
There was a problem hiding this comment.
Very interesting. I now realize I have several personal projects that should be RB_GC_GUARDing some strings.
Owner
|
Build failures look unrelated to this fix. |
Collaborator
Author
Fortunately |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intermediate String object wasn't stored, so that the underlying memory could be free'd before the C string was processed.
Fixes #705