Conversation
- Add --import-subnet-ids CLI flag (comma-separated, e.g. '0,1,2') - Remove hardcoded attestation-committee-count == 1 enforcement - Add ImportSubnetIDs and AttestationCommitteeCount to node.Config
- Change Topics.SubnetAttestation to SubnetAttestations map[uint64]*pubsub.Topic - JoinTopics accepts []uint64 subnet list instead of single subnetID - SubscribeTopics spawns a goroutine per subnet attestation topic - Add GetSubnetTopic helper for subnet-based topic lookup
…storage - Store gossip signatures unconditionally in ProcessAttestation, ProcessSubnetAttestation, and ProcessBlock - Subnet filtering is now handled at the P2P subscription layer, so only relevant attestations reach the store
- Compute deduplicated subnet IDs from import subnets + validator-derived subnets (validatorID %% committeeCount), with aggregator fallback to subnet 0 - Wire AttestationCommitteeCount into ValidatorDuties - Route attestation publish to correct subnet topic per validator - Update validator_test.go for multi-topic Topics struct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #165
This PR implements a comprehensive suite of node-level capabilities that brings gean to full 100% compliance with tracking the latest devnet3 specifications, specifically the Subnet Network Topology feature defined in leanSpec PR #486 (Gean Issue #165).
1. Subnet Network Topology (Issue #165)
Follows leanSpec PR #482 requirements to move attestation filtering to the network subscription layer, optimizing fork-choice store performance and establishing correct P2P mesh health for non-aggregators.
--import-subnet-idsconfiguration flag and removes the hardcodedattestation-committee-count=1enforcement.validator_id % committee_count, plus explicit import IDs and aggregator fallback.isAggregatorchecks from theforkchoicelayer since gossip signature ingest is now securely filtered at the P2P edge.PublishAttestationnow routes signatures accurately to their spec-assigned computational subnet topics.Testing Performed