Skip to content

feat: support vector notation for length in note.json#96

Merged
bczech merged 2 commits into
mainfrom
GDR-2846
May 8, 2026
Merged

feat: support vector notation for length in note.json#96
bczech merged 2 commits into
mainfrom
GDR-2846

Conversation

@bczech
Copy link
Copy Markdown
Contributor

@bczech bczech commented May 5, 2026

No description provided.

@bczech bczech requested a review from a team as a code owner May 5, 2026 10:53
@bczech bczech requested review from darsoo and gladkia May 5, 2026 10:53
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the gDRstyle package to version 1.11.2, introducing support for vector notation in the length field of the note.json configuration. The validation logic in R/check.R was updated to use the %in% operator, allowing multiple valid lengths for a single note check. Additionally, the note.json configuration was refactored to consolidate entries, and a new test case was added to verify the changes. I have no feedback to provide.

@darsoo darsoo requested a review from j-smola May 7, 2026 11:44
Copy link
Copy Markdown
Contributor

@j-smola j-smola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

@bczech bczech merged commit 181608a into main May 8, 2026
2 of 3 checks passed
@bczech bczech deleted the GDR-2846 branch May 8, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants