Collapse RichHtmlPreview warning + buttons after user picks a mode#150
Open
jamessi1989 wants to merge 1 commit into
Open
Collapse RichHtmlPreview warning + buttons after user picks a mode#150jamessi1989 wants to merge 1 commit into
jamessi1989 wants to merge 1 commit into
Conversation
The Rich/Non-Rich choice header stayed pinned above the preview for the rest of the session, consuming ~100-150px in already-cramped embedded iframes. Once the user has clicked either button the decision is made and the warning has served its purpose. Remove the header element on either click. Applied in previewers/betatest per CONTRIBUTING.md. Fixes gdcc#149
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
previewers/betatest/js/richhtml.jsonly, per CONTRIBUTING.md.Change
Two-character (well, two-call) edit —
header.remove()is appended to each click handler.headeris already in scope as avardeclared a few lines earlier.I intentionally kept this PR minimal: just the collapse fix. The shortened warning text and an optional "Switch view" toggle mentioned in the issue are deferred — happy to follow up in a separate PR if the maintainers want them.
Test plan
<script>or<head>to a Dataverse instance and open its preview pane.<script>/<head>and verify the previewer still renders directly with no warning (unchanged behaviour).