test: harden fixtures and streamline CI - #83
Open
gbaudrit wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR follows a complete review of the repository test suites and CI execution path.
Testingweb host in a single data directory and deletes owned SQLite/data-protection files on shutdown;Data:TestingDirectoryas unconfigured and creates an owned temporary directory;Testingstorage fallbacks under<ContentRoot>/.agentstration, even whenData:Directoryis customized;Data:TestingDirectorywhen they own cleanup, including startup-failure scenarios;DoNotParallelizeguard around environment-variable tests;build.ymlworkflow, whose platform, AEP, and container jobs were fully duplicated byci.yml;McpToolCatalogTests.csin a dedicated commit.Audit findings
agentstration-*entries had accumulated in%TEMP%on the review machine. Existing files were deliberately not deleted by this PR.SqliteConnection.ClearAllPools()calls were unsafe after enabling class-level parallelism. Cleanup is now scoped to the database files owned by each fixture..github/workflows/build.ymlrepeated the complete platform test, AEP test, and container build already covered (with newer actions, formatting, timeouts, and Windows lifecycle coverage) by.github/workflows/ci.yml.Compatibility
Data:Directorycontinues to configure identity, scheduler, data-protection, and related general data paths outsideTestingas before.<ContentRoot>/.agentstration/*.dboutsideTesting, unless their explicitData:*Pathsetting is provided.Testingenvironment; this PR does not migrate or relocate production data.Before / after
Validation
dotnet format Agentstration.slnx --no-restore --verify-no-changes— passeddotnet build Agentstration.slnx --configuration Release --no-restore— 0 warnings, 0 errorsdotnet test Agentstration.slnx --configuration Release --no-build— 539 total, 537 passed, 2 optional skipped, 0 faileddotnet build aep/Aep.slnx --configuration Release --no-restore— 0 warnings, 0 errorsdotnet test aep/Aep.slnx --configuration Release --no-build— 9/9 passed