Respect GZ_PYTHON_INSTALL_PATH if passed as an argument (backport #1586)#1674
Open
mergify[bot] wants to merge 1 commit into
Open
Respect GZ_PYTHON_INSTALL_PATH if passed as an argument (backport #1586)#1674mergify[bot] wants to merge 1 commit into
mergify[bot] wants to merge 1 commit into
Conversation
Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com> Co-authored-by: Steve Peters <scpeters@openrobotics.org> (cherry picked from commit ae7ac38)
9 tasks
luca-della-vedova
approved these changes
Jun 25, 2026
luca-della-vedova
left a comment
luca-della-vedova
left a comment
Contributor
There was a problem hiding this comment.
DCO fails with a trivial error because of a different email address:
Commit sha: [2a2b142](https://github.com/gazebosim/sdformat/pull/1674/commits/2a2b142629f8a9259ab60d5b3982f9bfc716917b), Author: Jose Luis Rivero, Committer: Mergify; Expected "Jose Luis Rivero [jrivero@osrfoundation.org](mailto:jrivero@osrfoundation.org)", but got "Jose Luis Rivero [jrivero@honurobotics.com](mailto:jrivero@honurobotics.com)".
I think it can be safely overridden but will leave it open for a day or so in case anyone disagrees.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
The PR adds the ability to set the
GZ_PYTHON_INSTALL_PATHfrom CMake arguments by no overriding it if it is set. This is useful for paths injected by the different package managers and distributions.One use case is for the ROS vendor packages where the Python path is controlled by an
ament_pythonhelper call.Easier to see https://github.com/gazebosim/sdformat/pull/1586/files?w=1
Checklist
codecheckpassed (See contributing)GeNote to maintainers**: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.This is an automatic backport of pull request #1586 done by Mergify.