Feature/base#4
Merged
Merged
Conversation
Made-with: Cursor
The global /search endpoint requires authentication and returned 401 for unauthenticated (guest) requests, silently showing no results. Changes: - In guest mode, the "Projects" scope now falls back to GET /projects?search=...&visibility=public which works without a token. - Issues, Merge Requests, Commits and Code scopes are disabled (greyed out with a lock icon) in guest mode; clicking shows an amber notice with a Sign in link. - Added isError handling so API failures surface a readable message instead of silently showing an empty state. - Empty-state description is contextualised for guest vs authenticated. Made-with: Cursor
…pping The guest-mode queryFn returned a plain object whose item type didn't include optional GitLabSearchResult fields (state, filename, path, data), causing TypeScript to widen the union and reject property accesses in the render tree. Fix: annotate the mapped items as GitLabSearchResult so the return type is consistently PagedResult<GitLabSearchResult> in both branches. Made-with: Cursor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.