🧹 [code health improvement] Rename confusing constant DEFAULT_LOCAL_URL

src/core/config.ts

@@ -1,6 +1,6 @@
 import * as vscode from 'vscode';
 import { PredicteCommitConfig } from './types';
-import { DEFAULT_LOCAL_URL } from './constants';
+import { EMPTY_BASE_URL } from './constants';
 
 export function getConfig(): PredicteCommitConfig {
   const cfg = vscode.workspace.getConfiguration('predicteCommit');
@@ -12,7 +12,7 @@ export function getConfig(): PredicteCommitConfig {
     ignoredFiles: cfg.get<string[]>('ignoredFiles', ['*-lock.json', '*.svg', 'dist/**']),
     useLocal,
     localProvider: cfg.get<string>('localProvider', 'ollama'),
-    localBaseUrl: cfg.get<string>('localBaseUrl', DEFAULT_LOCAL_URL),
+    localBaseUrl: cfg.get<string>('localBaseUrl', EMPTY_BASE_URL),
     localModel: cfg.get<string>('localModel', ''),
     debugLogging: cfg.get<boolean>('debugLogging', false),
   };

src/core/constants.ts

@@ -1,4 +1,4 @@
-export const DEFAULT_LOCAL_URL = '';
+export const EMPTY_BASE_URL = '';
 
 export const DIFF_CAPS: { maxCharsPerFile: number; maxCharsTotal: number } = {
   maxCharsPerFile: 8000,

src/providers/local/index.ts

@@ -1,7 +1,7 @@
 import { postChatCompletion } from '../../ai/http';
 import type { GenerateRequest, GenerateResult, ProviderClient } from '../../ai/types';
 import { registerProvider } from '../../ai/registry';
-import { DEFAULT_LOCAL_URL } from '../../core/constants';
+import { EMPTY_BASE_URL } from '../../core/constants';
 
 export class LocalProvider implements ProviderClient {
   constructor(
@@ -29,8 +29,8 @@ const createLocalProvider = (id: string, defaultUrl: string) => {
     // If the user hasn't changed the URL (it's empty),
     // then use that provider's default.
     // Otherwise (user changed it), use what's in config.
-    if (baseUrl === DEFAULT_LOCAL_URL) {
-      // DEFAULT_LOCAL_URL is ''
+    if (baseUrl === EMPTY_BASE_URL) {
+      // EMPTY_BASE_URL is ''
       baseUrl = defaultUrl;
     }
 

src/test/integration/config.test.ts

@@ -2,7 +2,7 @@ import * as assert from 'assert';
 import { getConfig } from '../../core/config';
 import { PredicteCommitConfig } from '../../core/types';
 import { getEffectiveProviderId } from '../../core/logic';
-import { DEFAULT_LOCAL_URL } from '../../core/constants';
+import { EMPTY_BASE_URL } from '../../core/constants';
 
 suite('Config Test Suite', () => {
   test('getEffectiveProviderId', () => {
@@ -52,7 +52,7 @@ suite('Config Test Suite', () => {
     assert.strictEqual(cfg.useLocal, false);
     assert.strictEqual(cfg.localProvider, 'ollama');
     assert.deepStrictEqual(cfg.ignoredFiles, ['*-lock.json', '*.svg', 'dist/**']);
-    assert.strictEqual(cfg.localBaseUrl, DEFAULT_LOCAL_URL);
+    assert.strictEqual(cfg.localBaseUrl, EMPTY_BASE_URL);
     assert.strictEqual(cfg.localModel, '');
   });
 });