fix: add Write tool to sidebar agent + surface empty responses#631
Open
sternryan wants to merge 1 commit intogarrytan:mainfrom
Open
fix: add Write tool to sidebar agent + surface empty responses#631sternryan wants to merge 1 commit intogarrytan:mainfrom
sternryan wants to merge 1 commit intogarrytan:mainfrom
Conversation
Sidebar agent hardcodes --allowedTools to Bash,Read,Glob,Grep in both server.ts and sidebar-agent.ts, preventing Claude from creating files (CSVs, exports, etc.) when asked from the sidebar. Also surfaces a "Done (no text output)" notice when Claude finishes without producing text, instead of leaving an empty response bubble. Addresses TODOS.md P1: "Sidebar agent needs Write tool + better error visibility"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Writeto--allowedToolsin bothserver.ts(line 433) andsidebar-agent.ts(line 165), enabling the sidebar agent to create files (CSVs, exports, etc.) when users ask.agent-emptyCSS class for the notice stylingAddresses the P1 TODO: "Sidebar agent needs Write tool + better error visibility"
Changes
browse/src/server.tsWriteto--allowedToolsbrowse/src/sidebar-agent.tsWriteto fallback--allowedToolsextension/sidepanel.jsagent_donefires with noagentTextElextension/sidepanel.css.agent-emptystyle (muted, italic, 12px)Test plan
bun test test/skill-validation.test.ts test/gen-skill-docs.test.ts-- 601/601 pass