feat: case-insensitive formulas and cell references#110
Merged
Conversation
Make `=sum(a1:a2)` evaluate the same as `=SUM(A1:A2)`. The lexer now accepts any ASCII letter at the start of an identifier or cell reference and normalizes the column letters to uppercase, so downstream code (parser, evaluator, dependency graph, file I/O) is unchanged. `col_label_to_index` is also case-insensitive so the `:sort` command accepts lowercase column labels. Closes #108 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ulas # Conflicts: # crates/cell-sheet-core/src/formula/eval.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
=sum(a1:a2)evaluates the same as=SUM(A1:A2), andtrue/falsework alongsideTRUE/FALSE.col_label_to_indexis also case-insensitive, so:sort aworks.Closes #108
Test plan
cargo test— 526 tests pass, including new regression tests intoken.rs,eval.rs, andmodel.rscargo fmt --all --checkcargo clippy --workspace --all-targets --all-featuresclean=sum(a1:a2)in the TUI to confirm🤖 Generated with Claude Code