fix(formula): bound expand_range to prevent OOM on giant ranges (#72)#104
Merged
Merged
Conversation
…itfra#72) Signed-off-by: SAY-5 <saiasish.cnp@gmail.com>
Owner
|
Lgtm, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #72.
expand_rangeincrates/cell-sheet-core/src/formula/eval.rsallocated oneCellPosper cell in the range, so=SUM(A1:XFD1048576)would try to materialise ~16 billion entries and OOM-kill the editor before any formula error could surface. This caps a single range at 1,000,000 cells (with overflow-safe arithmetic) and returns#VALUE!past that, matching the issue's proposed fix. Regression test added ineval.rsto lock the bound in place.