ci: build artifacts after release-plz publishes#102
Merged
Conversation
Use release-plz outputs to continue artifact builds in the same trusted release workflow because tags created with GITHUB_TOKEN do not trigger a second workflow run. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-plzoutputs to build and upload artifacts in the samerelease.ymlrun after crates.io publishing succeeds.workflow_dispatchwith a tag input so the existing draftv0.5.0release can be repaired without moving tags.Root cause
release-plzcreatedv0.5.0withGITHUB_TOKEN. GitHub does not trigger a new workflow run from tag pushes created byGITHUB_TOKEN, so the tag-gated build/upload jobs never ran.Test plan
ruby -e 'require "yaml"; YAML.load_file(".github/workflows/release.yml"); puts "release.yml yaml ok"'python3 -c 'import tomllib; tomllib.load(open("release-plz.toml", "rb")); print("release-plz.toml ok")'cargo fmt --all --check && cargo clippy --workspace --all-targets --all-features && cargo testMade with Cursor