Skip to content

Fix commit ID validation in gardenlinux.features.ArtifactBaseName - #371

Merged
NotTheEvilOne merged 1 commit into
mainfrom
dependabot/pip/click-8.4.2
Nov 14, 2026
Merged

NotTheEvilOne merged 1 commit into
mainfrom
dependabot/pip/click-8.4.2

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jun 29, 2026 •

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This PR fixes an issue if the commit hash is given and compared to the commit ID of an artifact base name in gardenlinux.features.ArtifactBaseName.new_instance(). As the commit hash is not shortened the comparison fails.

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Jun 29, 2026
@dependabot
dependabot Bot force-pushed the dependabot/pip/click-8.4.2 branch from 344a3b7 to 507405c Compare July 14, 2026 16:31
@NotTheEvilOne

Copy link
Copy Markdown
Contributor

@dependabot rebase

@NotTheEvilOne
NotTheEvilOne force-pushed the dependabot/pip/click-8.4.2 branch 2 times, most recently from 9f4a305 to e9a453c Compare November 14, 2026 12:35
@NotTheEvilOne NotTheEvilOne changed the title build(deps): bump click from 8.4.1 to 8.4.2 Fix commit ID validation in gardenlinux.features.ArtifactBaseName Nov 14, 2026
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
On-behalf-of: SAP <tobias.wolf@sap.com>
@NotTheEvilOne
NotTheEvilOne force-pushed the dependabot/pip/click-8.4.2 branch from e9a453c to 93d4555 Compare November 14, 2026 12:36
@NotTheEvilOne NotTheEvilOne self-assigned this Nov 14, 2026
@NotTheEvilOne NotTheEvilOne added bug-fix Fixes a bug and removed dependencies Pull requests that update a dependency file labels Nov 14, 2026

@NotTheEvilOne NotTheEvilOne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NotTheEvilOne
NotTheEvilOne merged commit 6dcf70c into main Nov 14, 2026
13 checks passed
@NotTheEvilOne
NotTheEvilOne deleted the dependabot/pip/click-8.4.2 branch November 14, 2026 12:39
@codecov

codecov Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.56%. Comparing base (841ed5e) to head (93d4555).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #371   +/-   ##
=======================================
  Coverage   91.56%   91.56%           
=======================================
  Files          51       51           
  Lines        3155     3155           
=======================================
  Hits         2889     2889           
  Misses        266      266           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix Fixes a bug python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant