Skip to content

fix: quote architecture in OCM extraIdentity to prevent int coercion#458

Merged
Kostov6 merged 1 commit into
masterfrom
fix/quote-arch-in-ocm-extra-identity
Apr 29, 2026
Merged

fix: quote architecture in OCM extraIdentity to prevent int coercion#458
Kostov6 merged 1 commit into
masterfrom
fix/quote-arch-in-ocm-extra-identity

Conversation

@ccwienk
Copy link
Copy Markdown
Member

@ccwienk ccwienk commented Apr 29, 2026

Summary

  • GHA expands ${{ matrix.args.arch }} into the inline YAML block without quotes, so 386 is parsed as a YAML integer rather than a string
  • extraIdentity values must be strings per the OCM spec (dict[str, str]), causing dacite.WrongTypeError when the component descriptor is deserialised downstream (e.g. in the release-notes action)
  • Fix: wrap the expression in single quotes so YAML treats it as a string literal

Test plan

  • Trigger a build for the windows/386 target and verify the release pipeline completes without WrongTypeError

@gardener-prow gardener-prow Bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 29, 2026
@ccwienk ccwienk requested a review from Kostov6 April 29, 2026 13:00
Copy link
Copy Markdown
Contributor

@Kostov6 Kostov6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2026
@gardener-prow
Copy link
Copy Markdown

gardener-prow Bot commented Apr 29, 2026

LGTM label has been added.

DetailsGit tree hash: 22d24b2ab2ec979eafe7692a510df3294a754d27

@gardener-prow
Copy link
Copy Markdown

gardener-prow Bot commented Apr 29, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kostov6

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2026
@Kostov6 Kostov6 merged commit dd73d9e into master Apr 29, 2026
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants