Change of handling of CORSIKA interaction tables. #1987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GernotMaier
requested review from
Copilot and
tobiaskleiner
and removed request for
tobiaskleiner
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a significant architectural change to how CORSIKA interaction tables are managed, moving them from being bundled in container images to being stored in a separate external repository.
Changes:
- CORSIKA interaction tables are now fetched from an external GitLab repository instead of being bundled in containers
- Added new environment variable
SIMTOOLS_CORSIKA_INTERACTION_TABLE_PATHto configure the location of interaction tables - Changed default high-energy interaction model from qgs3 to epos to avoid downloading gigabyte-sized QGSJet tables
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/simtools/settings.py |
Added corsika_interaction_table_path property with fallback to corsika_path for backward compatibility |
src/simtools/corsika/corsika_config.py |
Updated to use new interaction table path and modified EPOS flags configuration to support new table structure |
tests/unit_tests/corsika/test_corsika_config.py |
Updated tests to reflect new EPOS configuration and flexible parameter counts |
docker/Dockerfile-simtools-dev |
Removed QGSJet table download and installation, updated documentation |
docker/Dockerfile-corsika7 |
Modified to only copy NUCNUCCS table file instead of all interaction tables |
.github/workflows/build-simtools-dev.yml |
Removed QGSJet download job and dependency |
.github/workflows/CI-integrationtests.yml |
Added job to clone interaction tables repository and download artifact for integration tests |
.env_template |
Changed default interaction model to epos and added SIMTOOLS_CORSIKA_INTERACTION_TABLE_PATH variable |
docs/changes/1987.feature.md |
Documented the change in default interaction model |
docs/changes/1987.api.md |
Documented the API change and new setup requirements for users |
tobiaskleiner
approved these changes
Jan 21, 2026
Collaborator
tobiaskleiner
left a comment
tobiaskleiner
left a comment
There was a problem hiding this comment.
Thanks @GernotMaier, approving now.
Minor changes to fix issues with new sphinx
|
Contributor
Author
|
Thanks @tobiaskleiner ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important change for users and developers!!
CORSIKA interactions tables are not part of the CORSIKA7 container anymore and also not added to the simtools-dev container.
initial-setup- so you need to clone that). This includes QGSJet-II, QGSJet-III, EPOS, EGS4, etc tables./workdir/external/simpipe/simulation_software/corsika7-interaction-tables/interaction-tables/SIMTOOLS_CORSIKA_INTERACTION_TABLE_PATHpointing to that path (see example in .env_tableDo exactly the same for production. We do not expect that the interaction tables change very often.
There are a couple of changes to the images:
NUCNUCCSto be in the run directory.Please ignore the failing 'Docs' stages - this is due to an update in sphinx and is fixed in #1988.
Open points